Submission Details
Severity:
Deadline can always be changed
Summary
The set_deadline function checks fund.dealine_set for the DeadlineAlreadySet error, but fund.dealine_set never changed from initial value (false).
Vulnerability Details
pub fn set_deadline(ctx: Context<FundSetDeadline>, deadline: u64) -> Result<()> {
let fund = &mut ctx.accounts.fund;
if fund.dealine_set {
return Err(ErrorCode::DeadlineAlreadySet.into());
}
// ! deadline set is not set into true, deadline_set is being used as checking if its set or not, so deadline can be always changed.
fund.deadline = deadline;
Ok(())
}
Impact
The creator could just extend the deadline so the contributors could never do refunds.
Recommendations
Make sure to set the fund.dealine_set to true after setting the deadline.
pub fn set_deadline(ctx: Context<FundSetDeadline>, deadline: u64) -> Result<()> {
let fund = &mut ctx.accounts.fund;
if fund.dealine_set {
return Err(ErrorCode::DeadlineAlreadySet.into());
}
fund.deadline = deadline;
// set dealine_set to true
fund.dealine_set = true;
Ok(())
}
Updates
Appeal created
bube 8 months ago
Submission Judgement Published Assigned finding tags:
Deadline set flag is not updated in `set_deadline` function
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.