Submission Details
Severity:
Deadline flag not updated
Summary
Deadline status flag is not set after the deadline assignment in set_dealine, which will lead to wrong deadline managment mechanism.
Vulnerability Details
The code checks for
dealine_setbut never actually sets the flagInitial deadline check becomes functionally meaningless
Impact
The intended access control mechanism will be meaningless
Allows repeated deadline modifications
Tools Used
Manual code review
Test: By writing a test, where the owner of the Fund executes the function 2 times.
Recommendations
Setting the deadline_set property in the fund to true.
pub fn set_deadline(ctx: Context<FundSetDeadline>, deadline: u64) -> Result<()> {
let fund = &mut ctx.accounts.fund;
if fund.dealine_set {
return Err(ErrorCode::DeadlineAlreadySet.into());
}
fund.deadline = deadline;
fund.deadline_set = true;
Ok(())
}
Updates
Appeal created
bube 3 months ago
Submission Judgement Published Assigned finding tags:
Deadline set flag is not updated in `set_deadline` function
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.