Submission Details
Severity:
Withdraw() doesn't implement deadline check
Summary
Withdraw function is not checking if the deadlined has passed
Vulnerability Details
The withdraw function is ignoring the deadline of the fund and allows the creator to withdraw funds whenever they want.
Impact
The specification of the protocol is broken as the funds can be withdrawn by the owner at any point.
Tools Used
Recommendations
Add a deadline check:
if ctx.accounts.fund.deadline != 0 && ctx.accounts.fund.deadline > Clock::get().unwrap().unix_timestamp.try_into().unwrap() {
return Err(ErrorCode::DeadlineNotReached.into());
}
Updates
Appeal created
bube 2 months ago
Submission Judgement Published Assigned finding tags:
No deadline check in `withdraw` function
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.