The contract contains inconsistent and incorrect naming of deadline_set related variables across various functions fund_create(), set_deadline()
and the Fund struct
. This issue may lead to confusion during maintenance and could potentially cause errors in future modifications.
In the contract, the deadline_set variable is inconsistently named. For example, in the_ fundcreate
_function the deadline__set is initialized as dealine_set
, in the Fund struct and set_deadline
function it is referenced with a misspelled name (dealine_set
). This inconsistency in naming conventions can cause misunderstandings during code review and maintenance, and may lead to bugs if future updates assume a consistent naming convention.
Increases the risk of human error during code maintenance or when extending functionality.
Can lead to misinterpretation of the code’s logic regarding deadline handling.
May result in unintended behavior if new changes rely on the incorrectly named variables.
Manual code review
Standardize the naming of deadline-related variables across the entire codebase.
Rename dealine_set
to deadline_set
in the Fund struct and update all its references in the contract functions.
This is strong informational finding, there is no impact for the protocol. The variable is the same on all places.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.