Submission Details
Severity:
refund function is not updating `fund.amount_raised`
Summary
fund.amount_raisedis not being decreased when the contributor gets a refund.
Vulnerability Details
fund.amount_raisedis not being decreased when the contributor gets a refund, this makes the crowfund fund looks like they have money but in reality they don't.
pub fn refund(ctx: Context<FundRefund>) -> Result<()> {
let amount = ctx.accounts.contribution.amount;
if ctx.accounts.fund.deadline != 0 && ctx.accounts.fund.deadline > Clock::get().unwrap().unix_timestamp.try_into().unwrap() {
return Err(ErrorCode::DeadlineNotReached.into());
}
**ctx.accounts.fund.to_account_info().try_borrow_mut_lamports()? =
ctx.accounts.fund.to_account_info().lamports()
.checked_sub(amount)
.ok_or(ProgramError::InsufficientFunds)?;
**ctx.accounts.contributor.to_account_info().try_borrow_mut_lamports()? =
ctx.accounts.contributor.to_account_info().lamports()
.checked_add(amount)
.ok_or(ErrorCode::CalculationOverflow)?;
// Reset contribution amount after refund
ctx.accounts.contribution.amount = 0;
Ok(())
}
Impact
without updating fund.amount_raised the crowdfunding will display incorrect funds raised and it can reach the goal without actually having the real funds.
Tools Used
manual
Recommendations
update fund.amount_raisedafter the user getting his refund.
Updates
Appeal created
bube 2 months ago
Submission Judgement Published Assigned finding tags:
`amount_raised` not updated in `refund` function
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.