Submission Details
Severity:
wrong conditional check in the `contribute` function
Summary
contribute function executes wrong conditional.
Vulnerability Details
the contributefunction is incorrect because we need to check if the deadline exists and is in the future to NOT revert but it's checking if deadline is not zero and is in the past return error.
if fund.deadline != 0 && fund.deadline < Clock::get().unwrap().unix_timestamp.try_into().unwrap() {
return Err(ErrorCode::DeadlineReached.into());
}
Impact
wrong logic that breaks the program.
Tools Used
manual
Recommendations
should check if the deadline exists and is in the future instead.
Updates
Appeal created
bube 5 months ago
Submission Judgement Published Reason: Design choice
Assigned finding tags:
[Invalid] Contributions are allowed before the deadline is initialized.
There is no problem users to contribute to a given campaign before the deadline is initialized. The issue is when the users refund before the deadline is set.
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.