Submission Details
Severity:
fund.amount_raised is not reset after withdrawal in withdraw()
Summary
fund.amount_raised is not reset after withdrawal in withdraw()
Vulnerability Details
The withdraw function transfers all funds from the fund account to the creator account but does not reset fund.amount_raised after the withdrawal.
pub fn withdraw(ctx: Context<FundWithdraw>) -> Result<()> {
let amount = ctx.accounts.fund.amount_raised;
**ctx.accounts.fund.to_account_info().try_borrow_mut_lamports()? =
ctx.accounts.fund.to_account_info().lamports()
.checked_sub(amount)
.ok_or(ProgramError::InsufficientFunds)?;
**ctx.accounts.creator.to_account_info().try_borrow_mut_lamports()? =
ctx.accounts.creator.to_account_info().lamports()
.checked_add(amount)
.ok_or(ErrorCode::CalculationOverflow)?;
Ok(())
}
}
Impact
This can lead to misleading records of total funds raised.
Tools Used
Manual review.
Recommendations
Reset fund.amount_raised to zero after the funds are withdrawn.
Updates
Appeal created
bube 7 months ago
Submission Judgement Published Assigned finding tags:
`amount_raised` is not reset to 0 in `withdraw` function
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.