Submission Details
Severity:
EggNFT can be set more than once
Summary
EggNFT can be set more than once on setEggNFT on EggVault.sol
Vulnerability Details
function setEggNFT(address _eggNFTAddress) external onlyOwner {
require(_eggNFTAddress != address(0), "Invalid NFT address");
// not checking if eggNFT is already initialized
eggNFT = EggstravaganzaNFT(_eggNFTAddress);
}
Impact
EggstravaganzaNFT can always be changed, and if the depositor already deposit the egg before the eggNFT is changed, they cannot have withdraw it anymore on the new one.
Tools Used
Manual Review
Recommendations
Check if eggNFT is already have the address or already initialized using boolean flags, or checking if address is not 0.
Updates
Lead Judging Commences
m3dython 4 months ago
Submission Judgement Published Assigned finding tags:
State corruption
Changing the NFT contract address doesn't update the storedEggs and eggDepositors mappings
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.