Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Public functions in `EggVault` not used internally

Description: The EggVault::depositEgg, EggVault::withdrawEgg, and EggVault::isEggDeposited are marked as public functions but aren't being called anywhere inside the EggVault contract. Instead, the EggVault::depositEgg is called within the EggHuntGame contract. These functions should all be marked as external.

Recommended Mitigation:

- function withdrawEgg(uint256 tokenId) public {
+ function withdrawEgg(uint256 tokenId) external {
...
- function isEggDeposited(uint256 tokenId) public view returns (bool) {
+ function isEggDeposited(uint256 tokenId) external view returns (bool) {
...
- function depositEgg(uint256 tokenId, address depositor) public {
+ function depositEgg(uint256 tokenId, address depositor) external {
Updates

Lead Judging Commences

m3dython Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.