Submission Details
Severity:
Return value of `EggstravaganzaNFT::mintEgg` is ignored in the `EggHuntGame::searchForEgg` function
Description: The EggstravaganzaNFT::mintEgg function returns a boolean but in the EggHuntGame::searchForEgg function it's not taken into account at all.
// src/EggHuntGame.sol
function searchForEgg() external {
...
eggNFT.mintEgg(msg.sender, eggCounter);
...
}
// src/EggstravaganzaNFT.sol
function mintEgg(address to, uint256 tokenId) external returns (bool) {
require(msg.sender == gameContract, "Unauthorized minter");
_mint(to, tokenId);
totalSupply += 1;
return true;
}
Recommended Mitigation: There are two mitigations:
The return value from
EggstravaganzaNFT::mintEggshould be checked and handled in theEggHuntGame::searchForEggfunction.If it's not needed, the return value of
EggstravaganzaNFT::mintEggcan be removed.
Updates
Lead Judging Commences
m3dython 7 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Unused return value
Returns a boolean value that isn't utilized by its caller
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.