Submission Details
Severity:
Missing check for maximum eggs found allows unlimited minting per player
Vulnerability Details
The searchForEgg function lacks a mechanism to limit the number of eggs a single player can find. When the condition random < eggFindThreshold is met, an egg is minted and the player's count is incremented without any upper bound check.
if (random < eggFindThreshold) {
eggCounter++;
//@audit-issue no check for max eggs found, user can call this function as much as they want when random is below threshold (due to no randomness issue)
eggsFound[msg.sender] += 1;
eggNFT.mintEgg(msg.sender, eggCounter);
emit EggFound(msg.sender, eggCounter, eggsFound[msg.sender]);
}
Impact
A single player can mint an unlimited number of egg NFTs, especially if combined with the predictability of the pseudo-random number generation.
Recommendation
Implement a maximum limit on the number of eggs each user is allowed to find and mint.
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.