Description: In the EggVault contract, events such as EggDeposited and EggWithdrawn are emitted after state changes but before external calls. While this practice does not introduce immediate vulnerabilities, it is generally advisable to emit events after all external interactions to ensure that events accurately reflect the final state of the contract.
Recommendation: Reorder the functions to emit events after external calls. This ensures that events are only emitted if the external calls succeed, maintaining accurate and reliable event logs.
Standard practice for clarifying important contract behaviors
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.