Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Event Emission Timing

Description: In the EggVault contract, events such as EggDeposited and EggWithdrawn are emitted after state changes but before external calls. While this practice does not introduce immediate vulnerabilities, it is generally advisable to emit events after all external interactions to ensure that events accurately reflect the final state of the contract.​

Recommendation: Reorder the functions to emit events after external calls. This ensures that events are only emitted if the external calls succeed, maintaining accurate and reliable event logs.

Updates

Lead Judging Commences

m3dython Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Event Emission

Standard practice for clarifying important contract behaviors

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.