Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Invalid

we need to use safeTransferFrom instead of transferFrom

Summary

We are not checking whether the receiver contract handles the NFTs or not

Vulnerability Details

EggVault::withdrawEgg function is using transferFrom and for a better safety check we need to use ERC721::safeTransferFrom from openzeppelin

Impact - Medium

LikelyHood - High

Tools Used

Manul Review

Recommendations

use ERC721::safeTransferFrom instead of ERC721::transferFrom

And need to add IERC721Receiver in both EggHuntGame and EggVault contracts

Updates

Lead Judging Commences

m3dython Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.