Submission Details
Severity:
State Variable Changes Lack Event Emissions in some functions of `Eggstravaganza` protocol.
Summary
When changing the state of a variable it requires emiting an event. Which is not the case in some functions of the`Eggstravaganza` protocol :
- `setEggFindThreshold()` which is changing the game difficulty in `EggHUntGame.sol`.
- `mintEgg()` creates a new NFT in `EggstravaganzaNFT.sol`.
- `setGameContract()` sets the game contract in `EggstravaganzaNFT.sol`.
- `setEggNFT()` set the NFT contract in `EggVault.sol`.
Since there is no emission of event in `mintEgg()`, users don't know if their NFT got minted.
Emiting events enable offchain indexers to track the changes.
Impact
Off-chain systems cannot track protocol changes
Users lack visibility into critical parameter updates
Recommendation
Emit Events for Critical State Changes
Updates
Lead Judging Commences
m3dython 8 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Event Emission
Standard practice for clarifying important contract behaviors
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.