Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Unused return value from mintEgg()

Description:
The searchForEgg() function calls eggNFT.mintEgg() but ignores its return value:

// @audit-info return not used
eggNFT.mintEgg(msg.sender, eggCounter);

Impact:
While the function has require() checks, ignoring the return value means:

  1. Potential missed error handling if mint fails

  2. Could mask reentrancy issues

  3. Poor code quality practice

Recommended Mitigation:
Either:

  1. Remove the return value from mintEgg() if not needed

  2. Or properly handle the return value in searchForEgg()

Likelihood and Impact

  • Impact: Low

  • Likelihood: Low

  • Severity: Low

Updates

Lead Judging Commences

m3dython Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Unused return value

Returns a boolean value that isn't utilized by its caller

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!