Submission Details
Severity:
String Return Type Increases Gas Consumption
Description: The EggHuntGame::getGameStatus function returns a human-readable string, which is not gas-efficient. Using strings in smart contracts, especially as return types, can significantly increase gas costs and should be avoided unless absolutely necessary.
Recommended Mitigation: Return a uint8 or a custom enum instead of a string, which can then be interpreted off-chain.
+ enum GameState { NotStarted, Active, Elapsed, Inactive }
function getGameStatus() external view returns (GameState) {
if (gameActive) {
if (block.timestamp < startTime) {
- return "Game not started yet";
+ return GameState.NotStarted;
} else if (block.timestamp >= startTime && block.timestamp <= endTime) {
- return GameState.Active;
+ return true;
} else {
- return "Game time elapsed";
+ return GameState.Elapsed;
}
} else {
- return "Game is not active";
+ return GameState.Inactive;
}
}
Updates
Lead Judging Commences
m3dython 2 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimization
Strategy to save gas and minimize transaction costs
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.