Submission Details
Severity:
`public` functions not used internally could be marked `external`
Summary
Using a public function can cost a lot of gas, if not used internally.
Vulnerability Details
src/EggVault.sol:
function depositEgg(uint256 tokenId, address depositor) public {
.
.
.
function withdrawEgg(uint256 tokenId) public {
.
.
.
function isEggDeposited(uint256 tokenId) public view returns (bool) {
Impact
It will cost a lot of gas
Tools Used
Foundry
Aderyn
Recommendations
consider marking it as external if it is not used internally.
- function depositEgg(uint256 tokenId, address depositor) public {
+ function depositEgg(uint256 tokenId, address depositor) external {
.
.
.
- function withdrawEgg(uint256 tokenId) public {
+ function withdrawEgg(uint256 tokenId) external {
.
.
.
- function isEggDeposited(uint256 tokenId) public view returns (bool) {
+ function isEggDeposited(uint256 tokenId) external view returns (bool) {
Updates
Lead Judging Commences
m3dython 2 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimization
Strategy to save gas and minimize transaction costs
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.