Submission Details
Severity:
Redundant Line of Code
Summary
The check
if (block.timestamp < startTime)
return "Game not started yet";
inside gameActive == true is indeed redundant
Vulnerability Details
If
gameActive == true, the game should already be past itsstartTimeby definitionThere's no scenario where
gameActiveis true butblock.timestamp < startTime
/// @notice Returns a human-readable status of the game.
function getGameStatus() external view returns (string memory) {
if (gameActive) {
if (block.timestamp < startTime) {
return "Game not started yet";
} else if (block.timestamp >= startTime && block.timestamp <= endTime) {
return "Game is active";
} else {
return "Game time elapsed";
}
} else {
return "Game is not active";
}
}
Impact
increases gas cost by introducing unnecessary checks
Tools Used
mannual review
Recommendations
The testGameStartAndEnd function still passes
function getGameStatus() external view returns (string memory) {
if (!gameActive) {
return "Game is not active";
}
// Only these checks are needed when gameActive == true
if (block.timestamp <= endTime) {
return "Game is active";
} else {
return "Game time elapsed";
}
}
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.