Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

The owner can change the `EggVault::eggNFT` address after users have deposited into the vault, which could prevent users from withdrawing their NFTs

Description: The EggVault::setEggNFT function is restricted to the owner, which is good. However, there is no mechanism to prevent the owner from maliciously changing the NFT contract address after deposits have been made.

Impact: Changing the NFT address makes it impossible for users to withdraw their NFTs, effectively locking all deposited assets in the vault

Recommended Mitigation: Add a one-time initialization for the NFT contract or require a timelock for changes.

Updates

Lead Judging Commences

m3dython Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

State corruption

Changing the NFT contract address doesn't update the storedEggs and eggDepositors mappings

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!