Eggstravaganza

Summary

The EggVault constructor does not initialize eggNFT, requiring a separate setEggNFT call. If forgotten, the vault becomes unusable.

Vulnerability Details

• eggNFT is address(0) until setEggNFT is called, but there’s no check in depositEgg or withdrawEgg.

• If setEggNFT is never called, all vault functions will revert due to ownerOf calls on address(0).

Impact

• Permanent loss of functionality if deployment scripts omit setEggNFT.

Tools Used

Manual review of initialization flow.

Recommendations

• Initialize eggNFT directly in the constructor.

• Add a require(eggNFT != address(0)) check in critical functions.