Submission Details
Severity:
Missing Events After State Changes
Summary
Several functions modify state variables without emitting corresponding events.
Vulnerability Details
The following functions perform state changes but fail to emit events:
1. `setEggFindThreshold` in `EggHuntGame.sol`
2. `setEggNFT` in `EggVault.sol`
3. `setGameContract` in `EggstravaganzaNFT.sol`
4. `mintEgg` in `EggstravaganzaNFT.sol`
Impact
While the lack of events does not directly affect the game’s core functionality, it limits the ability of off-chain indexers and monitoring tools to track important changes, reducing transparency and debuggability.
Tools Used
Manual Code Review
Recommendations
Emit appropriate events in the listed functions whenever state variables are modified.
Updates
Lead Judging Commences
m3dython 8 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Event Emission
Standard practice for clarifying important contract behaviors
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.