Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Missing Events After State Changes

Summary

Several functions modify state variables without emitting corresponding events.

Vulnerability Details

The following functions perform state changes but fail to emit events:

1. `setEggFindThreshold` in `EggHuntGame.sol`
2. `setEggNFT` in `EggVault.sol`
3. `setGameContract` in `EggstravaganzaNFT.sol`
4. `mintEgg` in `EggstravaganzaNFT.sol`

Impact

While the lack of events does not directly affect the game’s core functionality, it limits the ability of off-chain indexers and monitoring tools to track important changes, reducing transparency and debuggability.

Tools Used

  • Manual Code Review

Recommendations

Emit appropriate events in the listed functions whenever state variables are modified.

Updates

Lead Judging Commences

m3dython Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Event Emission

Standard practice for clarifying important contract behaviors

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!