Submission Details
Severity:
Minting an NFT from outside of the `EggHuntGame` contract can break all minting
[H-2] Minting an NFT from outside of the EggHuntGame contract can break all minting
Description: If an NFT with a is minted outside the game contract and the tokenId is low enough the game will try to mint the same tokenID and revert.
Impact: The game contract only increments the eggCounter value after a successsful mint. If a mint reverts, that counter will never increment and the game contract can not mint any more NFTs.
Recommended Mitigation: Add a function exists in the EggstravaganzaNFT contract and check if an NFT with the tokenId exists before trying to mint in the searchForEgg() function
if (random < eggFindThreshold) {
eggCounter++;
eggsFound[msg.sender] += 1;
+ while(eggNFT.exists(eggCounter)) {
eggCounter++;
}
+ eggCounter++;
+ }
eggNFT.mintEgg(msg.sender, eggCounter);
emit EggFound(msg.sender, eggCounter, eggsFound[msg.sender]);
}
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.