Eggstravaganza

First Flight #37
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Invalid

The EggstravaganzaNFT:mintEgg always returns true

[M-3] The EggstravaganzaNFT:mintEgg always returns true

Description: EggVault:mintEgg always returns true no matter the outcome of the call

Impact: Since the _mint function will revert on failure and not return false, there could be confusion what the return result from mintEgg actually means.

Recommended Mitigation: Remove the returns (bool) function since the result is never read.

Updates

Lead Judging Commences

m3dython Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Unused return value

Returns a boolean value that isn't utilized by its caller

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!