Submission Details
Severity:
No Cap on eggCounter Growth
Summary
Vulnerability Details
if (random < eggFindThreshold) {
eggCounter++;
eggsFound[msg.sender] += 1;
eggNFT.mintEgg(msg.sender, eggCounter);
emit EggFound(msg.sender, eggCounter, eggsFound[msg.sender]);
}
The searchForEgg() function increments a global eggCounter and mints NFTs without any upper bound.
Without a cap:
Players could farm an unlimited number of eggs.
mintEgg()could be spammed if the pseudo-randomness is manipulated.The
eggCountercould overflow in the long term (though unlikely withuint256, still theoretically possible).Game balance, rarity mechanics, or metadata tied to token IDs may be unintentionally affected.
Impact
Unlimited minting can lead to devaluation of NFTs.
Tools Used
Recommendations
Introduce a cap or maximum number of eggs (e.g., MAX_EGGS) and enforce it:
uint256 public constant MAX_EGGS = 10000;
require(eggCounter < MAX_EGGS, "All eggs have been found");
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.