Summary

EggCounter can increase without an upper limit.

Vulnerability Details

There is no maximum number of eggs you can get.

Impact

This can cause the system to overflow and produce errors. Since uint 256 is used

Tools Used

Recommendations

Recommendation to set a maximum egg limit and the ability to change it.

uint256 public maxEggSupply = 10_000;

function setMaxEggSupply(uint256 newMaxSupply) external onlyOwner {

require(newMaxSupply > eggCounter, "New supply must exceed current count");

maxEggSupply = newMaxSupply;

Also with this you can regulate the end of the game, when all the eggs are found and the egg counter is full the game can be over, as further search will give an error. And the egg counter after transferring them to the deposit in the vault will need to be reset.