Submission Details
Severity:
Insufficient Allowance Check
Summary
joinGameWithTokenchecks token balance but not allowance, leading to potential reverts.
Vulnerability Details
The following code:
function joinGameWithToken(uint256 _gameId) external {
Game storage game = games[_gameId];
require(game.state == GameState.Created, "Game not open to join");
require(game.playerA != msg.sender, "Cannot join your own game");
require(block.timestamp <= game.joinDeadline, "Join deadline passed");
require(game.bet == 0, "This game requires ETH bet"); //@audit This game requires Token bet
require(winningToken.balanceOf(msg.sender) >= 1, "Must have winning token"); //@audit no checks for matching bets!
// Transfer token to contract
winningToken.transferFrom(msg.sender, address(this), 1);
game.playerB = msg.sender;
emit PlayerJoined(_gameId, msg.sender);
}
The transfer functionality is implemented without an allowance check
Impact
Poor user experience and potential confusion from the users.
Tools Used
Manual code review
Recommendations
Add a require allowance check
Updates
Appeal created
m3dython 2 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Broken Token Game Creation
createGameWithToken and joinGameWithToken functions will revert because they attempt transferFrom without requiring the user to first approve
m3dython 2 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Broken Token Game Creation
createGameWithToken and joinGameWithToken functions will revert because they attempt transferFrom without requiring the user to first approve
Rewards breakdown
nSLOC
349This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.