Rock Paper Scissors

Summary

The GameState.Revealed state is not used in the RockPaperScissors contract. This state is defined in the GameState enum but is never assigned or checked in any of the contract's functions.

Vulnerability Details

Impact

Maybe the GameState.Revealed state was intended to be used to indicate that both players have revealed their moves. However, it is not currently being used in the contract, which could lead to confusion or errors in the game logic.

Tools Used

Manual review.

Recommendations

Either remove the GameState.Revealed state from the enum or implement it in the game logic to indicate that both players have revealed their moves. This could be done by checking if both players have revealed their moves and then setting the game state to GameState.Revealed.