Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Unused Revealed State in Game Lifecycle

Location:

Enum GameState, GameState.Revealed

Description:

The GameState.Revealed enum value exists in the code but is never assigned or checked anywhere in the contract. This indicates either an incomplete implementation or unnecessary code that adds confusion.

Impact:

Potential developer confusion.

Dead or misleading logic.

Missed opportunity for better game state transitions.

Recommendation:

Either fully implement the Revealed state in the game lifecycle or remove it.

Improve state modeling for clarity.

Updates

Appeal created

m3dython Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

m3dython Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.