Rock Paper Scissors

Summary

The GameState.Revealed enum value is defined but never used throughout the contract. All state transitions go directly from Committed to Finished or Cancelled, bypassing any intermediate Revealed state.

Vulnerability Details

Including unused enum values can cause confusion for auditors, developers, and maintainers. It implies a possible missing logic branch or incomplete feature, even if no functional issue exists today.

Impact

• Reduces code clarity

• May mislead future maintainers into assuming intermediate logic exists

Tools Used

• Manual code review

Recommendations

Remove the Revealed enum value from GameState if it's not part of the intended logic:

If a reveal-specific state is planned, consider implementing the missing state transition clearly to match this intent.