Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

[L-2] No upper bound on `totalTurns` in Game Creation

Description: The _totalTurns parameter in createGameWithEth and createGameWithToken determines how many rounds are played in a match. While the contract enforces that it must be a positive odd number, there is no upper limit

Impact: This could allow users to create games with an excessive number of turns (e.g., hundreds or thousands), which could lead to games with absurd turn amounts.

Recommended Mitigation: Consider imposing a reasonable upper bound on _totalTurns to maintain game simplicity

Updates

Appeal created

m3dython Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

m3dython Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.