Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

L176 - Wrong error in require statement. Should be "This game doesn't require ETH bet"

Summary

The error that will be emitted if the require statement in L176 fails is wrong. It is "This game requires ETH bet", while the ETH bet required is 0 since the joinGameWithToken() function uses winningtokens as bets.

Vulnerability Details

A wrong error has been used along with the require statement in L176. Instead of using "This game doesn't require ETH bet", "This game requires ETH bet" ahs been used.

Impact

Confusion for players. (Low)

Tools Used

Manual Review

Recommendations

Change the error to "This game doesn't require ETH bet"

Updates

Appeal created

m3dython Lead Judge about 2 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

m3dython Lead Judge about 2 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.