Submission Details
Severity:
Game state `Revealed` is defined but never used
Description: Game state Revealed is defined in the enum but never used in the contract.
Impact: Players can be confused by the unused state, leading to misunderstandings about the game flow, or make wrong actions.
Recommended Mitigation: change game state to Revealed in revealMove function
function revealMove(uint256 _gameId, uint8 _move, bytes32 _salt) external {
...
+ game.state = GameState.Committed;
if (msg.sender == game.playerA) {
game.moveA = _move;
game.saltA = _salt;
game.state = GameState.Revealed; // change to Revealed
} else {
game.moveB = _move;
game.saltB = _salt;
game.state = GameState.Revealed; // change to Revealed
}
...
}
Updates
Appeal created
m3dython about 2 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational
Code suggestions or observations that do not pose a direct security risk.
m3dython about 2 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational
Code suggestions or observations that do not pose a direct security risk.
Rewards breakdown
nSLOC
349This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.