Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: high
Invalid

Reentrancy in ETH Transfers

Summary: ETH transfers to players occur before state changes in several functions.

Details: The _finishGame(), _handleTie(), and _cancelGame() functions make ETH transfers before updating critical state, potentially allowing reentrancy attacks.

Impact: A malicious contract receiving ETH could reenter and drain funds.

Recommendation: Follow checks-effects-interactions pattern and use ReentrancyGuard:

Updates

Appeal created

m3dython Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.