Rock Paper Scissors

Summary

The function createGameWithEth permits creating a game with only 1 turn, as long as the total number of turns is an odd number greater than zero. While this passes the current validation, it introduces potential gameplay imbalances and violates typical assumptions in turn-based two-player games. The logic does not ensure that both players have an opportunity to act, which can lead to unfair outcomes and poor user experience.

Vulnerability Details

Issue:

• The check allows _totalTurns = 1, which leads to:

  • A game that may end before the second player takes any action

  • Misleading game flow if players expect at least one turn each

  • Potential for strategic abuse if player A can win instantly

Impact

Player A could dominate or end the game before Player B can act.

Tools Used

Manual review

Recommendations

Enforce a minimum of 3 turns when creating a game to guarantee at least one move per player and prevent edge-case abuse: