Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Contract Owner role does not exist

Summary

The Contract Owner role as described in the project README.md does not exist.

Vulnerability Details

Although there are three actors described in the project README.md, the Contract Owner and the Admin are the same role.

There is one usage of the function RockPaperScissors::owner() which simply returns the adminAddress

Impact

The contract owners should aware that the Admin owns the RockPaperScissor and any transfer of the Admin role is also a transfer of the Contract Owner role.

Tools Used

Manual Review.

Recommendations

It is recommended to remove the project README.md reference to the Contract Owner.

It is also recommended to remove RockPaperScissors::owner() and instead utilize the Ownable2Step contract from OpenZeppelin to control ownership.

Updates

Appeal created

m3dython Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.