Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Invalid

No State Update After Player B Joins in both the `joinGameWithEth` and `joinGameWithToken` functions

Summary

Game state remains Created after Player B joins, allowing unintended behaviors in downstream functions.

Vulnerability Details

Both joinGameWithEth and joinGameWithToken allow Player B to join but do not update the game.state. As a result, later functions that depend on a new state (e.g., Committed) may behave incorrectly or fail.

Impact

If the game remains in the Created state, functions gated by other states might be bypassed or blocked incorrectly.

Tools Used

Recommendations

After Player B successfully joins, update the game state:

game.state = GameState.Committed;
Updates

Appeal created

m3dython Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.