Rock Paper Scissors

Summary

Unbounded game settings

Vulnerability Details

Game contract implementation does not provide upper limits for the following game settings:

• timeoutInterval

• joinTimeout

• totalTurns

Along with that, there are is no handling of:

• how many games a single player can create

• how many games a single opponent can join into

• how much tokens could be minted

Impact

• each player can create unlimited number of games

• each player can join into unlimited number of games

• unlimited amount of tokens could be minted

Tools Used

Manual review

Recommendations

Implement reasonable and adecuate rate limits for the following game settings:

• timeoutInterval

• joinTimeout

• totalTurns

Along with that should be imlemented a reasonable restrictions for:

• how many games a single player can create

• how many games a single opponent can join into

Update implementation of winner token to have total suply.