Rock Paper Scissors

First Flight #38
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

State Change Without Event

Summary

There are state variable changes in the setAdmin function but no event is emitted.

Vulnerability Details

The setAdmin function is responsible for setting a new admin but there is no event emitted.

Tools Used

Aderyn

Recommendations

Consider adding an event and emitting it after the admin has been changed.

+ event AdminChanged(address oldAdmin, address newAdmin);
setAdmin(address _newAdmin) external {
require(msg.sender == adminAddress, "Only admin can set new admin");
require(_newAdmin != address(0), "Admin cannot be zero address");
adminAddress = _newAdmin;
+ emit AdminChanged(oldAdmin, _newAdmin);
}
Updates

Appeal created

m3dython Lead Judge about 2 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

m3dython Lead Judge about 2 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational

Code suggestions or observations that do not pose a direct security risk.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.