Submission Details
Severity:
Missing increment reviewCount in giveReview() __LevelOne.sol
Summary
The giveReview function does not increment reviewCount, causing the review tracking logic to break.
Vulnerability Details
Without incrementing reviewCount, the value remains at 0 for every student, regardless of how many reviews they receive.
function giveReview(address _student, bool review) public onlyTeacher {
if (!isStudent[_student]) {
revert HH__StudentDoesNotExist();
}
require(reviewCount[_student] < 5, "Student review count exceeded!!!");
require(block.timestamp >= lastReviewTime[_student] + reviewTime, "Reviews can only be given once per week");
// where `false` is a bad review and true is a good review
if (!review) {
studentScore[_student] -= 10;
}
// Update last review time
lastReviewTime[_student] = block.timestamp;
emit ReviewGiven(_student, review, studentScore[_student]);
}
Impact
Students won't receive their review
Tools Used
Manual review
Recommendations
Without incrementing reviewCount, the value remains at 0 for every student, regardless of how many reviews they receive.
reviewCount[_student]++;
Updates
Lead Judging Commences
yeahchibyke 19 days ago
Submission Judgement Published Assigned finding tags:
reviewCount not updated
`reviewCount` for students is not updated after each review session
yeahchibyke 19 days ago
Submission Judgement Published Assigned finding tags:
reviewCount not updated
`reviewCount` for students is not updated after each review session
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.