Submission Details
Severity:
[EVMN-HH06] Incorrect Teacher Payment Calculation
Summary
Incorrect Teacher Payment Calculation
Vulnerability Details
The teacher payment calculation is incorrect. The current implementation calculates the total percentage for teachers but doesn't divide it among the teachers correctly:
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
Impact
High (High Impact, High Likelihood)
Tools Used
Manual review.
Recommendations
Fix the payment calculation to properly distribute among teachers:
// Calculate total teacher payment
uint256 totalTeacherPay = (bursary * TEACHER_WAGE) / PRECISION;
// Only proceed with payments if there are teachers
uint256 payPerTeacher = 0;
if (totalTeachers > 0) {
payPerTeacher = totalTeacherPay / totalTeachers;
for (uint256 n = 0; n < totalTeachers; n++) {
usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
}
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
incorrect teacher pay calculation
`payPerTeacher` in `graduateAndUpgrade()` is incorrectly calculated.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.