Submission Details
Severity:
[EVMN-HH08] Missing Check for Active Session in `giveReview()`
Summary
Missing Check for Active Session in giveReview()
Vulnerability Details
The giveReview() function does not check if the school is currently in session. This could allow teachers to give reviews outside of the school session.
function giveReview(address _student, bool review) public onlyTeacher {
// No check for inSession
// ...
}
Impact
Medium
Tools Used
Manual review
Recommendations
Add a check to ensure the school is in session:
function giveReview(address _student, bool review) public onlyTeacher {
if (!inSession) {
revert HH__NotInSession();
}
if (!isStudent[_student]) {
revert HH__StudentDoesNotExist();
}
// ...
}
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
session state not updated
`inSession` not updated after during upgrade
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.