Hawk High

Summary

• We are not updating bursary after sending usd to teacher and principal

• Hence we can keep track of the remaining 60% of the student fees

Vulnerability Details

• you can see that the usdc is transfered but the bursary is not modified to the correct value i.e it should be like below

  function graduateAndUpgrade(address _levelTwo, bytes memory) public onlyPrincipal {

  if (_levelTwo == address(0)) {

  revert HH__ZeroAddress();

  }

  ​

  uint256 totalTeachers = listOfTeachers.length;

  ​

  uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;

  uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;

  ​

  _authorizeUpgrade(_levelTwo);

  ​

  for (uint256 n = 0; n < totalTeachers; n++) {

  usdc.safeTransfer(listOfTeachers[n], payPerTeacher);

  }

  usdc.safeTransfer(principal, principalPay);

  bursary -= (payPerTeacher * totalTeachers) + principalPay;

  }

Impact

• cant track the remaining 60% of the amount

Tools Used

• brain

Recommendations

• add get function for bursary and update the graduateAndUpgrade contract as a above