Submission Details
Severity:
Incorrect reviewCount Check in giveReview
Summary
Incorrect reviewCount limit of 5 allows a potential 5th review, violating the 4-review rule.
Vulnerability Details
The giveReview function in LevelOne.sol checks reviewCount[_student] < 5, but the invariant requires exactly 4 reviews. This allows a potential 5th review (if reviewCount were incremented), which is inconsistent with the 4-review limit.
Impact
Minor inconsistency, manageable if reviewCount is fixed.
Tools Used
Manual code review.
Recommendations
Change the check to require(reviewCount[_student] < 4, "Student review count exceeded!!!");.
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
reviewCount not updated
`reviewCount` for students is not updated after each review session
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.