Hawk High
First Flight #39
Beginner FriendlySolidity
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

[L-1] There is no emission of event when the student graduated from level one to level two

The Best Audit Group

Summary

The graduateAndUpgrade() function performs a critical role by distributing funds to teachers and the principal and authorizing an upgrade to a new contract (LevelTwo). However, this function does not emit any event indicating that the graduation or upgrade has occurred. This omission leads to reduced transparency and hinders off-chain monitoring and audits of important state transitions.

function graduateAndUpgrade(address _levelTwo, bytes memory) public onlyPrincipal {
if (_levelTwo == address(0)) {
revert HH__ZeroAddress();
}
​
uint256 totalTeachers = listOfTeachers.length;
​
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;
​
_authorizeUpgrade(_levelTwo);
​
for (uint256 n = 0; n < totalTeachers; n++) {
usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
​
usdc.safeTransfer(principal, principalPay);
}

Vulnerability Details

There is no event emitted when:

  • The school year ends,

  • Funds are distributed,

  • The upgrade to a new implementation occurs.

Impact

It's difficult for auditors or stakeholders to determine when and where funds were disbursed.

Tools Used

Manual Review

Recommendations

Add event for better visibility

event GraduatedAndUpgraded(address indexed newImplementation, uint256 timestamp);
​
function graduateAndUpgrade(address _levelTwo, bytes memory) public onlyPrincipal {
if (_levelTwo == address(0)) {
revert HH__ZeroAddress();
}
​
uint256 totalTeachers = listOfTeachers.length;
​
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;
​
_authorizeUpgrade(_levelTwo);
​
for (uint256 n = 0; n < totalTeachers; n++) {
usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
​
usdc.safeTransfer(principal, principalPay);
​
emit GraduatedAndUpgraded(_levelTwo, block.timestamp);
}
​
​
Updates

Lead Judging Commences

yeahchibyke Lead Judge 6 months ago
Submission Judgement Published
Validated
Assigned finding tags:

no event

Event not emitted

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.