Submission Details
Impact:
Likelihood:
Nothing happens if the review is good, i.e. `review = true`
Summary
If the review is good, we don't change the students score.
Vulnerability Details
In LevelOne::giveReview, we update the student's score if the review is bad:
// where `false` is a bad review and true is a good review
if (!review) {
studentScore[_student] -= 10;
}
However, nothing happens if review = true. Therefore, the student's score can never be increased, even if the student deserves it.
Impact
The Student's score cannot be increased. However, not sure it's intended or not, thus, submitting as low.
Tools Used
Manual review
Recommendations
Increase the studentScore[_student]mapping value, and add a cap at 100 if needed.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.