Hawk High

Summary

There are no checks if the students are below the cutOffScore, which leads to upgrading these students to the next level.

Vulnerability Details

The invariant says:

Any student who doesn't meet the cutOffScore should not be upgraded

However, the cutOffScore is never checked inside LevelOne::graduateAndUpgrade.

Impact

The protocol will update to Level Two, even if any of the students are below the cutOffScore, which breaks the invariant quoted above. However, this can be preventing by expelling the student. Hence, leaving it as low-severity.

Tools Used

Manual Review

Recommendations

The easiest way is to make a for-loop which will check if all the students are above the cutOffScore. However, remember that for-loops consume a lot of gas.