Submission Details
Impact:
Likelihood:
[M-2] Only bad review is given to a student in `LevelOne::giveReview()` function
Description:
only bad reviews is given to a students instead of good and bad which will add or deducts 10 points from the score.
if (!review) {
studentScore[_student] -= 10;
}
Impact:
When a students deserved good reviews, he will not have any points, but when he gave bad reviews the systems will deduct 10 points from his score
Tools used:
Manual Reviews
Remediation:
Consider updating the following
- if (!review) {
- studentScore[_student] -= 10;
- }
+ if (!review) {
+ studentScore[_student] -= 10;
+ } else {
+ studentScore[_student] += 10;
+ }
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.