Submission Details
Severity:
All students must have 4 reviews before upgrade
Summary
There’s no check in graduateAndUpgrade that every student has exactly 4 reviews.
Vulnerability Details
There is no code related to System upgrade should not occur if any student has not gotten 4 reviews (one for each week)
Impact
Contradicts sixth rule of invariants.
Tools Used
Manual Review
Recommendations
Before upgrade, iterate through listOfStudents and ensure reviewCount[student] == 4.
// Ensure all students have exactly 4 reviews
for (uint256 i = 0; i < listOfStudents.length; i++) {
address student = listOfStudents[i];
require(reviewCount[student] == 4, "Student missing reviews");
}
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
cut-off criteria not applied
All students are graduated when the graduation function is called as the cut-off criteria is not applied.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.