Submission Details
Impact:
Likelihood:
Uses `block.timestamp` for comparisons is Dangerous comparisons
Summary
usage of `block.timestamp` can be manipulated by someone,Which will lead to Reviews can be given many times per week !
Vulnerability Details
<details><summary>code</summary>
``` javascript
function giveReview(address _student, bool review) public onlyTeacher {
if (!isStudent[_student]) {
revert HH__StudentDoesNotExist();
}
require(reviewCount[_student] < 5, "Student review count exceeded!!!");
@> require(block.timestamp >= lastReviewTime[_student] + reviewTime, "Reviews can only be given once per week");
if (!review) {
studentScore[_student] -= 10;
}
```
</details>
Impact
Any student can influance the result of review
<details><summary>code</summary>
``` javascript
require(block.timestamp >= lastReviewTime[_student] + reviewTime, "Reviews can only be given once per week");
```
</details>
Tools Used
Foundry
Recommendations
Avoid relying on `block.timestamp` .
Use a secure and decentralized source of comparaison, such as Chainlink VRF.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.