Summary

revert(); gives no information about why the transaction failed

Vulnerability Details

• Without a reason string or custom error gives no information to the user or developer about why the transaction failed.

• Best practice is to use custom errors (as you defined) or at least a reason string.

Impact

• It makes debugging and error handling much harder.

Tools Used

Manual Review

Recommendations

Case1:

You can define a new error for this case.

And then use it like this.

Case2:

Or, if you want to use a reason string.